Skip to content

Conversation

@akronim26
Copy link
Contributor

What was wrong?

Implementation of das-core was absent

How was it fixed?

Implements das-core

To-Do

@akronim26 akronim26 changed the title WIP: implement das-core feat: implement das-core (WIP) Dec 23, 2025
@akronim26 akronim26 marked this pull request as ready for review December 24, 2025 16:59
@akronim26 akronim26 changed the title feat: implement das-core (WIP) feat: implement das-core Dec 24, 2025
@KolbyML
Copy link
Contributor

KolbyML commented Dec 25, 2025

@akronim26 can you fix ci?

@akronim26
Copy link
Contributor Author

@akronim26 can you fix ci?

@KolbyML, I think the codebase should also allow using .map_err(|_| ...) in addition to .map_err(|err| ...). In cases like this, the underlying error isn’t needed or isn’t accessible at that layer. Alternatively, is there a preferred pattern for handling this kind of situation so that the code doesn’t end up forcing an unused error binding?

Actually the ci is failing due to this

@KolbyML
Copy link
Contributor

KolbyML commented Dec 25, 2025

@akronim26 can you fix ci?

@KolbyML, I think the codebase should also allow using .map_err(|_| ...) in addition to .map_err(|err| ...). In cases like this, the underlying error isn’t needed or isn’t accessible at that layer. Alternatively, is there a preferred pattern for handling this kind of situation so that the code doesn’t end up forcing an unused error binding?

Actually the ci is failing due to this

I disagree, I don't think we should be using InvalidByteLength for those, we should add a new error type to our this_error struct.

@KolbyML
Copy link
Contributor

KolbyML commented Dec 25, 2025

Those errors being hidden may not be related to InvalidByteLength

@akronim26 akronim26 marked this pull request as draft December 26, 2025 15:16
@akronim26 akronim26 marked this pull request as ready for review January 3, 2026 10:06
@akronim26
Copy link
Contributor Author

Hi @KolbyML! When you get a moment free, could you please review this?

Copy link
Contributor

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedback

@akronim26 akronim26 requested a review from KolbyML January 6, 2026 12:35
Copy link
Contributor

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just a few minor issues left

Copy link
Contributor

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: looks good

@KolbyML KolbyML merged commit 09ce74b into ReamLabs:master Jan 7, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants