-
Notifications
You must be signed in to change notification settings - Fork 73
feat: implement das-core #1094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement das-core #1094
Conversation
|
@akronim26 can you fix ci? |
Actually the ci is failing due to this |
I disagree, I don't think we should be using InvalidByteLength for those, we should add a new error type to our this_error struct. |
|
Those errors being hidden may not be related to InvalidByteLength |
|
Hi @KolbyML! When you get a moment free, could you please review this? |
KolbyML
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some feedback
KolbyML
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, just a few minor issues left
KolbyML
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
What was wrong?
Implementation of das-core was absent
How was it fixed?
Implements das-core
To-Do